gulp:ts: fix ts copy of constant file and inject test client .ts files automatically. #1836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set task constant as dependency to copy:constant and remove constant as dependency to transpile:client. As it then becomes redundant. Closes angular-fullstack#1830
… file. Refactor .ts injection of client .ts files into ts config file into function. Use new function to also inject client .ts test files given glob and config file. Closes angular-fullstack#1828
|
Yeah, |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes two issues: #1830 and #1828.
The fix for issue #1830 is pretty straight-forward and think the extra task and refactoring of the old task to an external function for issue #1828 are relatively small as well.
I am however a bit concerned that the refactoring might not necessarily comply with the preferred coding style for the repository. Should the function rather be a separate task? Or be moved into helper functions above?
Either way, I figure that the
injectTsConfigfunction could be used for a futuretsconfig.server.jsonandtsconfig.server.test.json. So think it's at least better than copy + paste.